On 4/9/2024 11:54 PM, Konrad Dybcio wrote: > > > On 4/5/24 09:49, Dikshita Agarwal wrote: >> >> >> On 3/27/2024 11:38 PM, Konrad Dybcio wrote: >>> A situation like: >>> >>> if (!foo) >>> goto bar; >>> >>> for (i = 0; i < foo; i++) >>> ...1... >>> >>> bar: >>> ...2... >>> >>> is totally identical to: >>> >>> for (i = 0; i < 0; i++) // === if (0) >>> ...1... >>> >>> ...2... >>> >>> Get rid of such boilerplate. >>> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >>> --- >>> drivers/media/platform/qcom/venus/pm_helpers.c | 10 ---------- >>> 1 file changed, 10 deletions(-) >>> >>> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c >>> b/drivers/media/platform/qcom/venus/pm_helpers.c >>> index ef4b0f0da36f..730c4b593cec 100644 >>> --- a/drivers/media/platform/qcom/venus/pm_helpers.c >>> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c >>> @@ -878,14 +878,10 @@ static int vcodec_domains_get(struct venus_core >>> *core) >>> .pd_flags = PD_FLAG_NO_DEV_LINK, >>> }; >>> - if (!res->vcodec_pmdomains_num) >>> - goto skip_pmdomains; >>> - >> this condition should still be there to skip calling >> dev_pm_domain_attach_list if vcodec_pmdomains_num is 0. > > That should be totally fine, within that function there's this bit > > if (num_pds <= 0) > return 0; > > which bails out gracefully > AFAIU, this condition won't be true eg: for 8916 and 8996. because in the else condition[1], num_pds will be non-zero, as there is one entry for power-domains in dtsi file for 8916, 8996 as well. [1]https://elixir.bootlin.com/linux/v6.9-rc5/source/drivers/base/power/common.c#L213 Am I missing something here? > Konrad
