Hi Hans,
On 22/04/24 1:39 pm, Hans Verkuil wrote:
Hi Sakari, Kieran, Umang,
On 17/04/2024 11:49, Sakari Ailus wrote:
Hi Hans, Mauro,
Here's a set of mainly camera sensor related patches for 6.10. In
particular, there are ov2680 and hi556 fixes form Hans and Fabio, your own
MC patch, fixes for imx335 from Kieran and Umang, DT fixes from Alexander
Stein and one Cadence csi2rx fix from Pratyush and finally my random series
of framework and ipu3-imgu driver fixes.
Please pull.
I get these compiler warnings when building:
drivers/media/i2c/imx335.c:219: warning: Function parameter or struct member 'cci' not described in 'imx335'
drivers/media/i2c/imx335.c:219: warning: Function parameter or struct member 'lane_mode' not described in 'imx335'
Can you take a look?
I see why.
If it is something trivial, then let me know what to add and I can make the
fix.
Can you please consider the following fixup! for this:
diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
index 0b06e86583f2..990d74214cc2 100644
--- a/drivers/media/i2c/imx335.c
+++ b/drivers/media/i2c/imx335.c
@@ -176,6 +176,7 @@ struct imx335_mode {
* @pad: Media pad. Only one pad supported
* @reset_gpio: Sensor reset gpio
* @supplies: Regulator supplies to handle power control
+ * @cci: CCI register map
* @inclk: Sensor input clock
* @ctrl_handler: V4L2 control handler
* @link_freq_ctrl: Pointer to link frequency control
@@ -185,7 +186,7 @@ struct imx335_mode {
* @exp_ctrl: Pointer to exposure control
* @again_ctrl: Pointer to analog gain control
* @vblank: Vertical blanking in lines
- * @lane_mode Mode for number of connected data lanes
+ * @lane_mode: Mode for number of connected data lanes
* @cur_mode: Pointer to current selected sensor mode
* @mutex: Mutex for serializing sensor controls
* @link_freq_bitmap: Menu bitmap for link_freq_ctrl
Regards,
Hans
The following changes since commit 836e2548524d2dfcb5acaf3be78f203b6b4bde6f:
media: usb: siano: Fix allocation of urbs (2024-04-16 00:02:53 +0200)
are available in the Git repository at:
git://linuxtv.org/sailus/media_tree.git tags/for-6.10-2-signed
for you to fetch changes up to eba1e47919b66797eb2479b7a7e39df0473003ce:
media: hi556: Add support for avdd regulator (2024-04-17 10:58:10 +0300)
----------------------------------------------------------------
V4L2 patches for 6.10
----------------------------------------------------------------
Alexander Stein (2):
media: dt-bindings: sony,imx290: Allow props from video-interface-devices
media: dt-bindings: i2c: use absolute path to other schema
Fabio Estevam (1):
media: ov2680: Do not fail if data-lanes property is absent
Hans Verkuil (1):
media: mc: mark the media devnode as registered from the, start
Hans de Goede (9):
media: ov2680: Stop sending more data then requested
media: ov2680: Drop hts, vts ov2680_mode struct members
media: ov2680: Add vblank control
media: ov2680: Add hblank control
media: ov2680: Add camera orientation and sensor rotation controls
media: hi556: Return -EPROBE_DEFER if no endpoint is found
media: hi556: Add support for reset GPIO
media: hi556: Add support for external clock
media: hi556: Add support for avdd regulator
Jai Luthra (1):
media: ti: j721e-csi2rx: Fix races while restarting DMA
Kieran Bingham (2):
media: imx335: Support 2 or 4 lane operation modes
media: imx335: Parse fwnode properties
Pratyush Yadav (1):
media: cadence: csi2rx: configure DPHY before starting source stream
Sakari Ailus (4):
media: v4l: Don't turn on privacy LED if streamon fails
media: staging: ipu3-imgu: Update firmware path
media: v4l2-ctrls: Return handler error in creating new fwnode properties
media: v4l: Guarantee non-NULL return from v4l2_find_nearest_size()
Umang Jain (4):
media: imx335: Use V4L2 CCI for accessing sensor registers
media: imx335: Use integer values for size registers
media: imx335: Fix active area height discrepency
media: imx335: Limit analogue gain value
.../bindings/media/i2c/galaxycore,gc0308.yaml | 2 +-
.../bindings/media/i2c/galaxycore,gc2145.yaml | 2 +-
.../devicetree/bindings/media/i2c/sony,imx214.yaml | 2 +-
.../devicetree/bindings/media/i2c/sony,imx290.yaml | 5 +-
.../devicetree/bindings/media/i2c/sony,imx415.yaml | 2 +-
drivers/media/i2c/Kconfig | 1 +
drivers/media/i2c/hi556.c | 105 +++-
drivers/media/i2c/imx335.c | 636 ++++++++++-----------
drivers/media/i2c/ov2680.c | 97 +++-
drivers/media/mc/mc-devnode.c | 5 +-
drivers/media/platform/cadence/cdns-csi2rx.c | 26 +-
.../media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 5 +-
drivers/media/v4l2-core/v4l2-common.c | 2 +-
drivers/media/v4l2-core/v4l2-ctrls-core.c | 3 +
drivers/media/v4l2-core/v4l2-subdev.c | 22 +-
drivers/staging/media/ipu3/ipu3-css-fw.c | 4 +-
drivers/staging/media/ipu3/ipu3-css-fw.h | 2 +
17 files changed, 515 insertions(+), 406 deletions(-)
