Hi Sakari, Thank you for the patch. On Tue, Apr 16, 2024 at 10:33:09PM +0300, Sakari Ailus wrote: > Add a media bus code for ov2740 camera sensor embedded data and document > it. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > Reviewed-by: Julien Massot <julien.massot@xxxxxxxxxxxxx> > --- > .../media/v4l/subdev-formats.rst | 70 +++++++++++++++++++ > include/uapi/linux/media-bus-format.h | 3 +- > 2 files changed, 72 insertions(+), 1 deletion(-) > > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst > index a04756092238..c99b58cb8c7b 100644 > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst > @@ -8596,3 +8596,73 @@ This mbus code are only used for "2-byte simplified tagged data format" (code > embedded data format codes. > > Also see :ref:`CCS driver documentation <media-ccs-routes>`. > + > +Omnivision OV2740 Embedded Data Format > +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > + > +The Omnivision OV2740 camera sensor produces the following embedded data format, > +indicated by mbus code MEDIA_BUS_FMT_OV2740_EMBEDDED. The format conforms to > +:ref:`CCS embedded data format <MEDIA-BUS-FMT-CCS-EMBEDDED>` up to level 1. > + > +.. flat-table:: Omnivision OV2740 Embedded Data Format. Octets at indices marked > + reserved or unused have been omitted from the table. The values > + are big endian byte order. s/are big endian/are in big endian/ > + :header-rows: 1 > + > + * - Offset > + - Size in bits (active bits if not the same as size) > + - Content description > + * - 4 > + - 16 (10--0) > + - Analogue gain > + * - 6 > + - 16 > + - Coarse integration time > + * - 10 > + - 8 > + - Dpc correction threshold v8 indicated this contained bits 9:2 of the value, was that wrong, or did it get dropped by mistake ? > + * - 15 > + - 16 > + - Output image width > + * - 17 > + - 16 > + - Output image height > + * - 23 > + - 8 > + - MIPI header revision number (2) > + * - 31 > + - 8 > + - Vertical (bit 1) and horizontal flip (bit 0) > + * - 32 > + - 8 > + - Frame duration A > + * - 33 > + - 8 > + - Frame duration B > + * - 34 > + - 8 > + - Context count (2) > + * - 35 > + - 8 > + - Context select I'm not sure to understand what those four values are. > + * - 54 > + - 8 > + - Data pedestal bits 9--2 > + * - 63 > + - 8 > + - Frame average bits 9--2 > + * - 64 > + - 16 > + - Digital gain red > + * - 66 > + - 16 > + - Digital gain greenr > + * - 68 > + - 16 > + - Digital gain blue > + * - 70 > + - 16 > + - Digital gain greenb > + * - 89 > + - 8 > + - Frame counter (starts at 1, wraps to 0 after 255) > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > index 03f7e9ab517b..13e68c2ccb61 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -183,7 +183,8 @@ > #define MEDIA_BUS_FMT_META_20 0x8006 > #define MEDIA_BUS_FMT_META_24 0x8007 > > -/* Specific metadata formats. Next is 0x9002. */ > +/* Specific metadata formats. Next is 0x9003. */ > #define MEDIA_BUS_FMT_CCS_EMBEDDED 0x9001 > +#define MEDIA_BUS_FMT_OV2740_EMBEDDED 0x9002 > > #endif /* __LINUX_MEDIA_BUS_FORMAT_H */ -- Regards, Laurent Pinchart
