On Mon, Apr 15, 2024 at 05:49:33PM +0300, Andy Shevchenko wrote: > On Mon, Apr 15, 2024 at 02:02:10PM +0200, Hans de Goede wrote: > > Drop the atomisp custom lm3554 flash driver, support for flash drivers > > using the custom atomisp flash interface is going to be removed from > > the atomisp driver. > > > > If flash supports for the lm3554 turns out to be necessary on some > > atomisp devices in the future then this should be re-implemented > > using the new include/linux/led-class-flash.h APIs. > > > > The atomisp specific lm3554 driver could still be usable as a reference > > for how to use / driver the lm3554 for a future re-implementation > > using standardized APIs, but for that it can be retrieved from > > the git history. > > FYI: The driver is already there as drivers/leds/leds-lm355x.c. > It might still need the binding to v4l2 subsystem, but still... Wow, it even *was* there when AtomISP has been added: commit b98d13c725920e9ab7696e0d7d19c4db1bdf6737 Author: G.Shark Jeong <gshark.jeong@xxxxxxxxx> Date: Wed Sep 5 15:05:58 2012 +0800 -- With Best Regards, Andy Shevchenko