Hi All, Here is a resend of my patch-series to add all controls required by libcamera to the ov2680 driver. Changes in v2: - Add error checking to __v4l2_ctrl_modify_range() and __v4l2_ctrl_s_ctrl() calls - Set hblank read-only flag after checking hdl->error (avoids the need for an if (ctrls->hblank) check) - Use hdl->error to error check v4l2_ctrl_new_fwnode_properties() This has been tested together with the atomisp using the simple pipelinehandler. This should also work in IPU3 based devices with an ov2680. Note the vblank control new default value after a mode-set call has been chosen so as to preserve the old behavior of always running at 30 fps, so as to not change behavior for any existing use-cases. Regards, Hans Hans de Goede (5): media: ov2680: Stop sending more data then requested media: ov2680: Drop hts, vts ov2680_mode struct members media: ov2680: Add vblank control media: ov2680: Add hblank control media: ov2680: Add camera orientation and sensor rotation controls drivers/media/i2c/ov2680.c | 90 ++++++++++++++++++++++++++++++-------- 1 file changed, 71 insertions(+), 19 deletions(-) -- 2.44.0
