Hello, On Fri, Apr 12, 2024 at 07:00:22AM +0000, Changhuang Liang wrote: > > media: staging: media: starfive: camss: Convert to platform > > remove callback returning void > > > > The .remove() callback for a platform driver returns an int which makes many > > driver authors wrongly assume it's possible to do error handling by returning > > an error code. However the value returned is ignored (apart from emitting a > > warning) and this typically results in resource leaks. > > > > To improve here there is a quest to make the remove callback return void. In > > the first step of this quest all drivers are converted to .remove_new(), which > > already returns void. Eventually after all drivers are converted, .remove_new() > > will be renamed to .remove(). > > > > Trivially convert this driver from always returning zero in the remove callback > > to the void returning variant. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > Reviewed-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx> > > But it seems that v1 is already merge. Hmm, it's not in next though. IMHO it would be a good idea to add the tree that has my patch staged to next. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
