On Tue, Nov 16, 2010 at 4:42 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > On Tuesday, November 16, 2010 22:32:57 David Ellingsworth wrote: >> Hans, >> >> I've had some patches pending for a while now that affect the dsbr100 >> driver. The patches can be seen here: >> http://desource.dyndns.org/~atog/gitweb/?p=linux-media.git in the >> dsbr100 branch. The first patch in the series fixes locking issues >> throughout the driver and converts it to use the unlocked ioctl. The >> series is a bit old, so it doesn't make use of the v4l2 core assisted >> locking; but that is trivial to implement after this patch. > > Would it be a problem for you if for 2.6.37 I just replace .ioctl by > .unlocked_ioctl? And do the full conversion for 2.6.38? That way the > 2.6.37 patches remain small. > If you look at the first patch in that series, you'll see that the conversion isn't that simple. There are a lot of places in that driver that should have been protected by a lock that weren't. At the moment, I think the BKL protects these areas from racing so just replacing the .ioctl with the .unlocked_ioctl here isn't a good solution for this driver. Applying the patch I've provided will however remove the BKL and the resolve all the locking issues as well. Regards, David Ellingsworth -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
