Hi Stefan, On 28/03/2024 03:05, Stefan Herdler wrote: > Hi Hans, > > last year I promised to take a look at the chackpatch warnings. > Well, it took a little longer then expected but here is the first result. > > This patchset should remove all chackpatch warnings and errors in the > ttpci budget driver(s) if applied completely. > > This is the first in a series of similar fixes for the SAA7146 related > drivers (at least that is my plan). > This first patchset is also a test for my whole tool chain. Please give > me some feedback if there is something, that could be improved next time. > > Initially I had planned to start with the AV7110 driver, but then decided > to start with this one, because it was the easiest one to fix. It didn't > had any complicated issues and the list of warnings was one of the > shortest among the SAA7146 drivers. If I run 'checkpatch.pl --strict' over these patches, then reports several of these warnings about the subject line: WARNING: A patch subject line should describe the change not the tool that found it I think if you fix that and post a v2 (fixing 04/11 and dropping 11/11), then I can merge it. Regards, Hans > > Regards > Stefan > > > Stefan Herdler (11): > media: ttpci: checkpatch fixes: whitespace and newlines > media: ttpci: checkpatch fixes: whitespace > media: ttpci: checkpatch fixes: comments > media: ttpci: checkpatch fixes: braces > media: ttpci: checkpatch fixes: export_symbol > media: ttpci: checkpatch fixes: assign_in_if > media: ttpci: checkpatch fixes: trailing_statements > media: ttpci: checkpatch fixes: constant_comparsation > media: ttpci: checkpatch fixes: miscellaneous > media: ttpci: checkpatch fixes: logging > media: ttpci: checkpatch fixes: msleep > > drivers/media/pci/ttpci/budget-av.c | 574 +++++++++++++------------- > drivers/media/pci/ttpci/budget-ci.c | 501 +++++++++++----------- > drivers/media/pci/ttpci/budget-core.c | 38 +- > drivers/media/pci/ttpci/budget.c | 170 ++++---- > drivers/media/pci/ttpci/budget.h | 19 +- > 5 files changed, 658 insertions(+), 644 deletions(-) > > -- > 2.34.0 > >
