Re: [PATCH] media: cxd2880: Add terminating new line to Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Dan,

* Thank you for the review comments, I appreciate it.

>On Monday, 8 April, 2024 at 12:25:10 pm IST, Dan Carpenter wrote:
>It should be on one line, with no blank line afterward.

-> https://lore.kernel.org/linux-media/20240311100407.1271331-1-ppandit@xxxxxxxxxx/

* Blank line? There is no blank line afterward.

>
>This isn't a bug, so don't add a Fixes.

-> https://lore.kernel.org/netdev/CAE8KmOx9-BgbOxV6-wDRz2XUasEzp2krqMPbVYYZbav+8dCtBw@xxxxxxxxxxxxxx/T/#t

* Some say add it, some say don't add it. IMO there's no harm in having fixes tag. Will send a revised patch without fixes if you insist.

* Do we need one without fixes tag?

Thank you.
---
  -Prasad





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux