On 4/3/24 12:48, Pavel Machek wrote: > Hi! > >> The sensor supports the clock lane either remaining in HS mode >> during frame blanking, or dropping to LP11. >> >> Add configuration of the mode via V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK. > >> + ret = imx258_write_reg(imx258, IMX258_CLK_BLANK_STOP, >> + IMX258_REG_VALUE_08BIT, >> + imx258->csi2_flags & V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK ? >> + 1 : 0); > > !! can be used to turn value into 1/0. I find it easier to read than ? > 1 : 0 combination, but possibly that's fine, too. > > Best regards, > Pavel > I assume you mean by using !!(imx258->csi2_flags & V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK) I can go ahead and use that instead
