Em 16-11-2010 19:54, Jarod Wilson escreveu: > On Tue, Nov 16, 2010 at 09:19:53PM +0100, Nicolas Kaiser wrote: >> I noticed that the second part of this conditional is always true. >> Would the intention be to strictly check on both chip_major and >> chip_minor? >> >> Signed-off-by: Nicolas Kaiser <nikai@xxxxxxxxx> > > Hrm, yeah, looks like I screwed that one up. You're correct, the intention > was to make sure we have a matching chip id high and one or the other of > the chip id low values. > > Acked-by: Jarod Wilson <jarod@xxxxxxxxxx> > I wander if it wouldn't be good to print something if the probe fails due to the wrong chip ID. It may help if someone complain about a different revision. Mauro. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html