On Wed, Apr 03, 2024 at 01:24:05PM +0200, Krzysztof Kozlowski wrote: > On 03/04/2024 13:20, Shreeya Patel wrote: > > On Wednesday, April 03, 2024 15:51 IST, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > > >> On 03/04/2024 11:24, Shreeya Patel wrote: > >>> On Thursday, March 28, 2024 04:20 IST, Shreeya Patel <shreeya.patel@xxxxxxxxxxxxx> wrote: > >>> > >>>> This series implements support for the Synopsys DesignWare > >>>> HDMI RX Controller, being compliant with standard HDMI 1.4b > >>>> and HDMI 2.0. > >>>> > >>> > >>> Hi Mauro and Hans, > >>> > >>> I haven't received any reviews so far. Hence, this is just a gentle reminder to review this patch series. > >> > >> Why did you put clk changes here? These go via different subsystem. That > >> might be one of obstacles for your patchset. > >> > > > > I added clock changes in this patch series because HDMIRX driver depends on it. > > I thought it is wrong to send the driver patches which don't even compile? > > Hm, why HDMIRX driver depends on clock? How? This sounds really wrong. > Please get it reviewed internally first. > > > > > Since you are a more experienced developer, can you help me understand what would > > be the right way to send patches in such scenarios? > > I am not the substitute for your Collabora engineers and peers. You do > not get free work from the community. First, do the work and review > internally, to solve all trivial things, like how to submit patches > upstream or how to make your driver buildable, and then ask community > for the review. I don't think Shreeya was asking for "free" work from the community. Her question wasn't trivial or obvious since reasonable people seem to sometimes disagree about where to send a patch especially if it's needed to make a series compile. I heard the issue was already resolved but had to say something since this accusation seemed so unfair. > > Best regards, > Krzysztof > >
