Hi Fabio,
Thank you for the patch.
On Mon, Apr 01, 2024 at 12:43:41PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@xxxxxxx>
>
> OV2680 has a single data lane MIPI interface.
>
> Document the clock-lanes and data-lanes properties to avoid
> the following dt-schema warning:
>
> imx7s-warp.dtb: camera@36: port:endpoint: Unevaluated properties are not allowed ('clock-lanes', 'data-lanes' were unexpected)
> from schema $id: http://devicetree.org/schemas/media/i2c/ovti,ov2680.yaml#
>
> While at it, also document the link-frequencies property as recommended
> by the following document:
>
> https://www.kernel.org/doc/html/v6.9-rc1/driver-api/media/camera-sensor.html#handling-clocks
>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxx>
> ---
> Changes since v1:
> - Keep the existing 'additionalProperties: false'. (Krzysztof)
> - Also document link-frequencies.
>
> .../bindings/media/i2c/ovti,ov2680.yaml | 20 ++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> index cf456f8d9ddc..a1cb08283818 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml
> @@ -50,9 +50,24 @@ properties:
> Definition of the regulator used as digital power supply.
>
> port:
> - $ref: /schemas/graph.yaml#/properties/port
> description:
> A node containing an output port node.
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
I recommend using
additionalProperties: false
as the bindings shouldn't allow all the other properties defined in
video-interfaces.yaml that are not applicable for this device. It will
require adding
remote-endpoint: true
to the properties below.
> +
> + properties:
> + clock-lanes:
> + const: 0
> +
> + data-lanes:
> + const: 1
I see there's an ongoing discussion in v1 about these two properties,
I'll let Sakari and you figure it out :-)
> +
> + link-frequencies: true
I think this one should one marked as mandatory.
>
> required:
> - compatible
> @@ -89,6 +104,9 @@ examples:
> port {
> ov2680_to_mipi: endpoint {
> remote-endpoint = <&mipi_from_sensor>;
> + clock-lanes = <0>;
> + data-lanes = <1>;
> + link-frequencies = /bits/ 64 <330000000>;
> };
> };
> };
--
Regards,
Laurent Pinchart
