On Wed, Mar 27, 2024 at 01:21:09PM +0200, Tomi Valkeinen wrote: > On 25/03/2024 00:08, Laurent Pinchart wrote: > > From: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > > > > Add a driver for the Unicam camera receiver block on BCM283x processors. > > It is represented as two video device nodes: unicam-image and > > unicam-embedded which are connected to an internal subdev (named > > unicam-subdev) in order to manage streams routing. > > Shouldn't this driver call get_frame_desc somewhere to get the VC and DT > for the streams? Generally speaking, yes. In practice, configuring the DT from the frame descriptor is probably not very useful, as CSI-2 sources that transmit image data using a DT that doesn't correspond to the media bus code are not very common and I don't expect this to be needed for unicam. Configuring the VC, on the other hand, seems to me like a better use case. I will add get_frame_desc support for the next version. -- Regards, Laurent Pinchart
