On Mon, Apr 01, 2024 at 12:19:16PM +0200, Krzysztof Kozlowski wrote: > On 01/04/2024 12:02, Krzysztof Kozlowski wrote: > > On 01/04/2024 05:00, Tzung-Bi Shih wrote: > >> Prepare to provide platform_device_id table. Shrink the driver name for > >> fitting to [1]. > > > > Instead of linking to external resources, please describe the problem > > and the bug you are fixing here. > > > >> > >> [1]: https://elixir.bootlin.com/linux/v6.8/source/include/linux/mod_devicetable.h#L608 > >> > >> Reviewed-by: Benson Leung <bleung@xxxxxxxxxxxx> > >> Signed-off-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx> > > > > Missing fixes tag and Cc-stable. > > Ah, now I read your answer to v1 discussion. So this was not a bug in > the first place? Hm, then probably my comment was not really correct and > we should not split it. Correct, this wasn't a bug in the first place. Only if moving the string into struct platform_device_id, the compiler emits errors about the oversize. I'm fine with both versions. But let's go back to adopt v1 (no split) if no strong objections. Thanks a lot for your review again.
