Hi Julien and Sakari, On 3/15/24 10:22, Sakari Ailus wrote: > Hi Julien, > > On Fri, Mar 15, 2024 at 10:03:45AM +0100, Julien Massot wrote: >> The ST VGXY61 sensors support multiple lane numbers, as >> well as lane mapping. > > Wow! This is the first time I see this on the sensor side. Should it be > separately mentioned? > > The driver appears to be handling this already. Yes it does :) You could just add the "The ST VGXY61 sensors support multiple lane numbers, as well as lane mapping." to the 'description' part. With that : Reviewed-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx> I'm not sure about who is required for a device tree patch to be merged though. > >> --- >> Changes in v2: >> Add minimum/maximum items to restrict lane index to 1..4. >> --- >> .../devicetree/bindings/media/i2c/st,st-vgxy61.yaml | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml >> index 8c28848b226a..a76434ecf23a 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml >> +++ b/Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml >> @@ -67,11 +67,11 @@ properties: >> data-lanes: >> description: >> CSI lanes to use >> + minItems: 1 >> + maxItems: 4 >> items: >> - - const: 1 >> - - const: 2 >> - - const: 3 >> - - const: 4 >> + minimum: 1 >> + maximum: 4 >> >> remote-endpoint: true >> > -- Regards, Benjamin
