Hi Hans,
[Adding DT folks]
On Thu, Mar 28, 2024 at 8:27 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> I think that what is necessary for your case with fixed dts file is:
>
> diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov2680.c
> index bcd031882a37..5c789b5a4bfb 100644
> --- a/drivers/media/i2c/ov2680.c
> +++ b/drivers/media/i2c/ov2680.c
> @@ -1179,6 +1179,8 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor)
> goto out_free_bus_cfg;
> }
>
> + ret = 0;
> +
> out_free_bus_cfg:
> v4l2_fwnode_endpoint_free(&bus_cfg);
> return ret;
>
> and that then replaces both your patches, can you give this a try ?
This works fine if I pass link-frequencies in the dts, thanks.
--- a/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx7s-warp.dts
@@ -210,6 +210,7 @@ ov2680_to_mipi: endpoint {
remote-endpoint = <&mipi_from_sensor>;
clock-lanes = <0>;
data-lanes = <1>;
+ link-frequencies = /bits/ 64 <340000000>;
};
};
};
Can we allow the probe to succeed even if 'link frequencies' is absent?
That was my goal on patch 1/2: to keep existing dtb's functional.
Otherwise, the old dtb's without 'link-frequencies' will be broken and I'm not
sure if the DT folks will accept a patch passing link-frequencies to
imx7s-warp.dts
as a fix to be backported to 6.6.
ovti,ov2680.yaml will also need to be changed to include 'link-frequencies' as
a required property.
Thoughts?
