> -----Original Message-----
> From: Julien Panis <jpanis@xxxxxxxxxxxx>
> Sent: Thursday, March 28, 2024 2:57 PM
> To: David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
> <pabeni@xxxxxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>; Alexei Starovoitov
> <ast@xxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>; Jesper Dangaard
> Brouer <hawk@xxxxxxxxxx>; John Fastabend <john.fastabend@xxxxxxxxx>;
> Sumit Semwal <sumit.semwal@xxxxxxxxxx>; Christian König
> <christian.koenig@xxxxxxx>; Simon Horman <horms@xxxxxxxxxx>; Andrew
> Lunn <andrew@xxxxxxx>; Ratheesh Kannoth <rkannoth@xxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; bpf@xxxxxxxxxxxxxxx;
> linux-media@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linaro-mm-
> sig@xxxxxxxxxxxxxxxx; Julien Panis <jpanis@xxxxxxxxxxxx>
> Subject: [PATCH net-next v5 1/3] net: ethernet: ti: Add accessors
> for struct k3_cppi_desc_pool members
>
> This patch adds accessors for desc_size and cpumem members. They may be
> used, for instance, to compute a descriptor index.
>
> Signed-off-by: Julien Panis <jpanis@xxxxxxxxxxxx>
> ---
> drivers/net/ethernet/ti/k3-cppi-desc-pool.c | 12 ++++++++++++
> drivers/net/ethernet/ti/k3-cppi-desc-pool.h | 2 ++
> 2 files changed, 14 insertions(+)
>
> diff --git a/drivers/net/ethernet/ti/k3-cppi-desc-pool.c b/drivers/net/ethernet/ti/k3-
> cppi-desc-pool.c
> index 05cc7aab1ec8..fe8203c05731 100644
> --- a/drivers/net/ethernet/ti/k3-cppi-desc-pool.c
> +++ b/drivers/net/ethernet/ti/k3-cppi-desc-pool.c
> @@ -132,5 +132,17 @@ size_t k3_cppi_desc_pool_avail(struct
> k3_cppi_desc_pool *pool) } EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_avail);
>
> +size_t k3_cppi_desc_pool_desc_size(struct k3_cppi_desc_pool *pool) {
> + return pool->desc_size;
Don't you need to add NULL check on pool ptr since this function is exported?
> +}
> +EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_desc_size);
> +
> +void *k3_cppi_desc_pool_cpuaddr(struct k3_cppi_desc_pool *pool) {
> + return pool->cpumem;
Same here.
> +}
> +EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_cpuaddr);
> +
> MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("TI K3 CPPI5 descriptors pool API"); diff --git
> a/drivers/net/ethernet/ti/k3-cppi-desc-pool.h b/drivers/net/ethernet/ti/k3-cppi-desc-
> pool.h
> index a7e3fa5e7b62..149d5579a5e2 100644
> --- a/drivers/net/ethernet/ti/k3-cppi-desc-pool.h
> +++ b/drivers/net/ethernet/ti/k3-cppi-desc-pool.h
> @@ -26,5 +26,7 @@ k3_cppi_desc_pool_dma2virt(struct k3_cppi_desc_pool
> *pool, dma_addr_t dma); void *k3_cppi_desc_pool_alloc(struct
> k3_cppi_desc_pool *pool); void k3_cppi_desc_pool_free(struct
> k3_cppi_desc_pool *pool, void *addr); size_t k3_cppi_desc_pool_avail(struct
> k3_cppi_desc_pool *pool);
> +size_t k3_cppi_desc_pool_desc_size(struct k3_cppi_desc_pool *pool);
> +void *k3_cppi_desc_pool_cpuaddr(struct k3_cppi_desc_pool *pool);
>
> #endif /* K3_CPPI_DESC_POOL_H_ */
>
> --
> 2.37.3
>
