On Thu, Mar 28, 2024 at 08:52:01AM +0000, Kieran Bingham wrote: > Quoting git@xxxxxxxxxxxx (2024-03-28 00:57:34) > > On 3/27/24 17:47, Conor Dooley wrote: > > > On Wed, Mar 27, 2024 at 05:17:03PM -0600, git@xxxxxxxxxxxx wrote: > > >> From: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > > >> > > >> imx258.yaml doesn't include the vendor prefix of sony, so > > >> rename to add it. > > >> Update the id entry and MAINTAINERS to match. > > >> > > >> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > > >> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > > > > > This is a v1 with my ack, something has gone awry here. It's also > > > missing your signoff. Did you pick up someone else's series? > > > > Yes, this is a continuation of Dave's work. I contacted him directly, > > and he mentioned that he is unable to submit a v2 any time soon and > > was open to someone else continuing it in his stead. Ah okay. Unfortunately I see so many binding patches pass by that I sometimes forget about what I already reviewed, and I did not remember this one at all. > > This is my first > > time submitting a patch via a mailing list, so I'm not sure if I'm > > missing something, but I only added my sign off for anything that > > actually included work from my side and not just bringing his patch > > forward to this patch series. Right. The rules are that you need to add it when you send someone's work, like chain of custody type of thing. > Your cover letter states v2, but the individual patches do not. > > Add the '-v2' (or, rather, next it will be '-v3') to git format-patch > when you save your series and it will add the version to each patch. You > can also add '-s' to that command I believe to add your SoB to each > patch. or a rebase will do it with --signoff: https://git-scm.com/docs/git-rebase#Documentation/git-rebase.txt---signoff Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
