Hi Laurent, On Thu, Mar 28, 2024 at 09:47:26AM +0000, Sakari Ailus wrote: > > > > - The internal flag indicates an internal pad that has no external > > > > connections. This can be used to model, for instance, the pixel array > > > > internal to an image sensor. As they are internal to entities, > > > > internal pads shall not be connected with links. > > > > > > I'd drop the sentence related to sensors. > > > > I'm fine with another example, or a more generic explanation, but with > > that sentence dropped, I think this will leave the reader wondering what > > an internal pad is and what it's used for. > > What we could and probably have here is that the internal sink pad > indicates a source of data. That's what it really is, whether that data is > image data or something else. > > So I'd change this to: > > The internal flag indicates an internal pad that has no external > connections. Such a pad shall not be connected with a link. The internal > pad flag is allowed only in conjunction with the sink pad flag. Together > the two flags indicate the pad is a source of data inside the entity. A similar text already exists in the following paragraph already so I don't think additions should be needed. > > > > > > > > > > + > > > > > > + The internal flag may currently be present only in a source pad where > > > > > > > > > > s/source/sink/ > > > > > > > > > > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > > > > > > + it indicates that the :ref:``stream <media-glossary-stream>`` > > > > > > + originates from within the entity. > > > > > > > > > > > > One and only one of ``MEDIA_PAD_FL_SINK`` and ``MEDIA_PAD_FL_SOURCE`` > > > > > > must be set for every pad. -- Regards, Sakari Ailus
