On 28/03/2024 00:17, git@xxxxxxxxxxxx wrote: > From: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > > There are a number of variants of the imx258 modules that can not > be differentiated at runtime, so add compatible strings for them. > > Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > Signed-off-by: Luigi311 <git@xxxxxxxxxxxx> > --- > .../devicetree/bindings/media/i2c/sony,imx258.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > index bee61a443b23..c7856de15ba3 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > @@ -14,10 +14,14 @@ description: |- > type stacked image sensor with a square pixel array of size 4208 x 3120. It > is programmable through I2C interface. Image data is sent through MIPI > CSI-2. > + There are a number of variants of the sensor which cannot be detected at > + runtime, so multiple compatible strings are required to differentiate these. > > properties: > compatible: > - const: sony,imx258 > + - enum: > + - sony,imx258 Two people working on patch but no one tested it before sending. Do not send untested code. It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof
