On Thu, Dec 21, 2023 at 5:23 PM Fei Shao <fshao@xxxxxxxxxxxx> wrote: > > Hi, > > This series includes some improvements around mtk_vcodec_mem_free() in > mtk_vcodec_util.c. > > I noticed that mtk_vcodec_mem_free() generates a spurious error if the > target DMA buffer has been freed previously: > mtk_vcodec_mem_free(),69: [MTK_V4L2][ERROR] 18000000.video-codec > dma_free size=0 failed! > > The warning is harmless, but it brings some confusion to our developers > and testing infra, so I sent this series to fix that with some minor > improvement for the driver alongside. > > The first two patches are for aesthetic and style improvements, the > third tries to make the error logs more informative, and the last adds > back the missing checks when calling the free function. > > Regards, > Fei > > v1: https://lore.kernel.org/all/20231113123049.4117280-1-fshao@xxxxxxxxxxxx/ > > Changes in v2: > - rebased on top of next-20231219 > - revise commit message for clearer intention and rationale > - update the error messages based on the suggestion > > Fei Shao (4): > media: mediatek: vcodec: Replace dev_name in error string > media: mediatek: vcodec: Drop unnecessary variable > media: mediatek: vcodec: Update mtk_vcodec_mem_free() error messages > media: mediatek: vcodec: Only free buffer VA that is not NULL > > .../mediatek/vcodec/common/mtk_vcodec_util.c | 23 +++++++++---------- > .../vcodec/decoder/vdec/vdec_av1_req_lat_if.c | 22 ++++++++++++------ > .../vcodec/encoder/venc/venc_h264_if.c | 5 ++-- > 3 files changed, 29 insertions(+), 21 deletions(-) Hi Hans, I'd like to get some attention for this series in case it has been overlooked. It still applies to next-20240327 without conflict. Please let me know if you have any feedback or concerns on this. Thank you, Fei > > -- > 2.43.0.472.g3155946c3a-goog >
