On Tuesday, November 16, 2010 06:29:53 Pawel Osciak wrote: > On Mon, Nov 15, 2010 at 17:10, Andrew Chew <AChew@xxxxxxxxxx> wrote: > > I'm looking at drivers/media/video/videobuf-dma-contig.c's __videobuf_alloc() routine. We call kzalloc() to allocate the videobuf_buffer. However, I don't see where the two lists (vb->stream and vb->queue) that are a part of struct videobuf_buffer get initialized (with, say, INIT_LIST_HEAD). > > > > Those are not lists, but list entries. Those members of > videobuf_buffer struct are used to put the buffer on one of the > following lists: stream is a list entry for stream list in > videobuf_queue, queue is used as list entry for driver's buffer queue. So? They still should be initialized properly. It's bad form to leave invalid pointers there. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
