On 22/03/2024 19:05, Conor Dooley wrote: > On Fri, Mar 22, 2024 at 06:59:18AM +0100, Krzysztof Kozlowski wrote: >> On 21/03/2024 21:43, Anatoliy Klymenko wrote: >>> diff --git a/include/dt-bindings/media/media-bus-format.h b/include/dt-bindings/media/media-bus-format.h >>> new file mode 100644 >>> index 000000000000..60fc6e11dabc >>> --- /dev/null >>> +++ b/include/dt-bindings/media/media-bus-format.h >>> @@ -0,0 +1,177 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */ >>> +/* >>> + * Media Bus API header >>> + * >>> + * Copyright (C) 2009, Guennadi Liakhovetski <g.liakhovetski@xxxxxx> >>> + * >>> + * This program is free software; you can redistribute it and/or modify >>> + * it under the terms of the GNU General Public License version 2 as >>> + * published by the Free Software Foundation. >> >> That's not true. Your SPDX tells something entirely different. >> >> Anyway, you did not explain why you need to copy anything anywhere. > > I assume by "copy anything anywhere" you mean "why did you copy a linux > uapi header into the bindings? Yes, I trimmed context too much. The reasoning of copying some UAPI and claiming it is a binding was: "Copy media-bus-formats.h into dt-bindings/media to suplement TPG DT node." so as seen *there is no reason*. Commit msg should explain why we are doing things. Best regards, Krzysztof
