> On 21/03/2024 1:17 pm, Changhuang Liang wrote: > > Hi, Hans > > > > Thanks for your comments. > > > >> On 01/03/2024 8:00 am, Changhuang Liang wrote: > >>> The pixel formats captured by the capture_raw video device depends > >>> on what pixel formats come from the source device. It is actually > >>> dump the source device data. So renamed it to capture_dump. > >> > >> I don't think 'dump' is a great name. I think what you really want to > >> say is 'unprocessed'. And usually that is indeed called 'raw capture'. > >> > > > > StarFive JH7110 SoC also supports the output of the raw format data from > ISP port, see: > > > > https://lore.kernel.org/all/20240306093334.9321-1-changhuang.liang@sta > > rfivetech.com/ > > > > So I think it is better to call the ISP output port "capture_raw". > > If it is processed by the ISP, how can it be 'raw'? Or do you mean that this uses > Bayer pixelformat? > > The normal convention AFAIK is that the term 'raw capture' generally means > that the sensor bayer data is captured without being processed (or only > minimal processing). > > Looking at: > > https://lore.kernel.org/all/20240306093334.9321-6-changhuang.liang@starfi > vetech.com/ > > I think you indeed mean that you can get the processed ISP data in bayer > format through a separate video device. So I would call that port > 'capture_bayer' and keep the 'capture_raw' name for the port from the CSI > receiver. > OK, will use this way. Regards, Changhuang
