Hi Sakari,
Thank you for the patch.
On Wed, Mar 13, 2024 at 09:24:55AM +0200, Sakari Ailus wrote:
> Add trivial S_ROUTING IOCTL support for drivers where routing is static.
> Essentially this means returning the same information G_ROUTING call would
> have done.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/v4l2-core/v4l2-subdev.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index a6107e440ef0..c8c435df92c8 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -930,6 +930,20 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg,
>
> memset(routing->reserved, 0, sizeof(routing->reserved));
>
> + /*
> + * If the driver doesn't support setting routing, just return
> + * the routing table here.
> + */
> + if (!v4l2_subdev_has_op(sd, pad, set_routing)) {
> + memcpy((struct v4l2_subdev_route *)(uintptr_t)routing->routes,
> + state->routing.routes,
> + min(state->routing.num_routes, routing->len_routes) *
> + sizeof(*state->routing.routes));
> + routing->num_routes = state->routing.num_routes;
> +
> + return 0;
> + }
> +
> for (i = 0; i < routing->num_routes; ++i) {
> const struct v4l2_subdev_route *route = &routes[i];
> const struct media_pad *pads = sd->entity.pads;
--
Regards,
Laurent Pinchart
