On Wed, Mar 13, 2024 at 7:54 AM Zhi Mao <zhi.mao@xxxxxxxxxxxx> wrote: > > This series adds YAML DT binding and V4L2 sub-device driver for Galaxycore's > GC05A2 5-megapixel 10-bit RAW CMOS 1/5" sensor, with an MIPI CSI-2 image data > interface and the I2C control bus. > > The driver is implemented with V4L2 framework. > - Async registered as a V4L2 sub-device. > - As the first component of camera system including Seninf, ISP pipeline. > - A media entity that provides one source pad in common. > - Used in camera features on ChromeOS application. > > Also this driver supports following features: > - manual exposure and analog gain control support > - vertical blanking control support > - test pattern support > - media controller support > - runtime PM support > - support resolution: 2592x1944@30fps, 1280x720@60fps Not even going to do a thorough review as one should learn on the previous reviews. Most of the comments that I had given to another driver submission are applicable here. So, waiting for v2 with all applicable being addressed. -- With Best Regards, Andy Shevchenko
