Hi Uwe,
thank you for your patch.
On Fri, Feb 23, 2024 at 01:59:07PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
> ---
> drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
> index 32c6619be9a2..bce821eb71ce 100644
> --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
> +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
> @@ -517,7 +517,7 @@ static int dcmipp_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int dcmipp_remove(struct platform_device *pdev)
> +static void dcmipp_remove(struct platform_device *pdev)
> {
> struct dcmipp_device *dcmipp = platform_get_drvdata(pdev);
> unsigned int i;
> @@ -534,8 +534,6 @@ static int dcmipp_remove(struct platform_device *pdev)
> media_device_cleanup(&dcmipp->mdev);
>
> v4l2_device_unregister(&dcmipp->v4l2_dev);
> -
> - return 0;
> }
>
> static int dcmipp_runtime_suspend(struct device *dev)
> @@ -588,7 +586,7 @@ static const struct dev_pm_ops dcmipp_pm_ops = {
>
> static struct platform_driver dcmipp_pdrv = {
> .probe = dcmipp_probe,
> - .remove = dcmipp_remove,
> + .remove_new = dcmipp_remove,
> .driver = {
> .name = DCMIPP_PDEV_NAME,
> .of_match_table = dcmipp_of_match,
> --
> 2.43.0
>
Regards,
Alain
