On Tue, Mar 05, 2024 at 11:52:15PM +0100, Andi Shyti wrote: > On Tue, Mar 05, 2024 at 07:48:30PM +0200, Andy Shevchenko wrote: ... > > +static int ir_spi_tx(struct rc_dev *dev, unsigned int *buffer, unsigned int count) > > this goes over 80 characters, though. Not an error, but not worth > a change either. It's only 82 characters and I consider this as an improvement in readability. It's quite pity that some of the subsystems are too conservative, hope this one is not an obstacle for them. > I'm not going block the patch as the rest is OK. > > Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> Thank you! Btw, don't you want to either add your entry into .mailcap and/or update your email address in this source file (and maybe others)? I Cc'ed you only after I looked closer to the sources... -- With Best Regards, Andy Shevchenko