On Mon, Mar 04, 2024 at 12:11:44PM +0100, Jacopo Mondi wrote: > Hi Laurent > > Ah > https://patchwork.linuxtv.org/project/linux-media/patch/20240223163012.300763-2-jacopo.mondi@xxxxxxxxxxxxxxxx/ > > same for the Y14 one > > I guess we have upported the same patch twice ? Indeed :-) > Whichever series gets in first wins I'm fine with that. > On Fri, Mar 01, 2024 at 11:32:21PM +0200, Laurent Pinchart wrote: > > From: Jean-Michel Hautbois <jeanmichel.hautbois@xxxxxxxxxxxxxxxx> > > > > This is a packed grey-scale image format with a depth of 12 bits per > > pixel. Two consecutive pixels are packed into 3 bytes. The first 2 bytes > > contain the 8 high order bits of the pixels, and the 3rd byte contains > > the 4 least significants bits of each pixel, in the same order. > > > > Add the entry in userspace API, and document it. > > > > Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@xxxxxxxxxxxxxxxx> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > .../userspace-api/media/v4l/pixfmt-yuv-luma.rst | 11 +++++++++++ > > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > > include/uapi/linux/videodev2.h | 1 + > > 3 files changed, 13 insertions(+) > > > > diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst > > index cf8e4dfbfbd4..a650ceda7cdb 100644 > > --- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst > > +++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-luma.rst > > @@ -114,6 +114,17 @@ are often referred to as greyscale formats. > > - ... > > - ... > > > > + * .. _V4L2-PIX-FMT-Y12P: > > + > > + - ``V4L2_PIX_FMT_Y12P`` > > + - 'Y12P' > > + > > + - Y'\ :sub:`0`\ [11:4] > > + - Y'\ :sub:`1`\ [11:4] > > + - Y'\ :sub:`1`\ [3:0] Y'\ :sub:`0`\ [3:0] > > + - ... > > + - ... > > + > > * .. _V4L2-PIX-FMT-Y14: > > > > - ``V4L2_PIX_FMT_Y14`` > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > > index f3697ff65817..69ac4482d844 100644 > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > @@ -1313,6 +1313,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > > case V4L2_PIX_FMT_Y10BPACK: descr = "10-bit Greyscale (Packed)"; break; > > case V4L2_PIX_FMT_Y10P: descr = "10-bit Greyscale (MIPI Packed)"; break; > > case V4L2_PIX_FMT_IPU3_Y10: descr = "10-bit greyscale (IPU3 Packed)"; break; > > + case V4L2_PIX_FMT_Y12P: descr = "12-bit Greyscale (MIPI Packed)"; break; > > case V4L2_PIX_FMT_Y8I: descr = "Interleaved 8-bit Greyscale"; break; > > case V4L2_PIX_FMT_Y12I: descr = "Interleaved 12-bit Greyscale"; break; > > case V4L2_PIX_FMT_Z16: descr = "16-bit Depth"; break; > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > > index 117a081c9db9..5122ac0c6765 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -599,6 +599,7 @@ struct v4l2_pix_format { > > #define V4L2_PIX_FMT_Y10BPACK v4l2_fourcc('Y', '1', '0', 'B') /* 10 Greyscale bit-packed */ > > #define V4L2_PIX_FMT_Y10P v4l2_fourcc('Y', '1', '0', 'P') /* 10 Greyscale, MIPI RAW10 packed */ > > #define V4L2_PIX_FMT_IPU3_Y10 v4l2_fourcc('i', 'p', '3', 'y') /* IPU3 packed 10-bit greyscale */ > > +#define V4L2_PIX_FMT_Y12P v4l2_fourcc('Y', '1', '2', 'P') /* 12 Greyscale, MIPI RAW12 packed */ > > > > /* Palette formats */ > > #define V4L2_PIX_FMT_PAL8 v4l2_fourcc('P', 'A', 'L', '8') /* 8 8-bit palette */ -- Regards, Laurent Pinchart
