Hi Helping out Guiliano to send the tested-by, he also says that 0408:4033 should be added to this patch. On Sun, 15 Jan 2023 at 21:52, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > The Quanta ACER HD User Facing camera reports a UVC 1.50 version, but > implements UVC 1.0a as shown by the UVC probe control being 26 bytes > long. Force the UVC version for that device. > > Reported-by: Giuliano Lotta <giuliano.lotta@xxxxxxxxx> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> Tested-by: Giuliano Lotta <giuliano.lotta@xxxxxxxxx> > --- > > Giuliano, I believe you've successfully tested this patch. If so, could > you reply with a Tested-by tag ? Just copying the following in your > reply will do: > > Tested-by: Giuliano Lotta <giuliano.lotta@xxxxxxxxx> > > drivers/media/usb/uvc/uvc_driver.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index 1a186abeb4fa..742eeaff333e 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -2429,6 +2429,17 @@ static const struct usb_device_id uvc_ids[] = { > .bInterfaceSubClass = 1, > .bInterfaceProtocol = UVC_PC_PROTOCOL_15, > .driver_info = (kernel_ulong_t)&uvc_ctrl_power_line_limited }, > + /* Quanta ACER HD User Facing */ > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > + | USB_DEVICE_ID_MATCH_INT_INFO, > + .idVendor = 0x0408, > + .idProduct = 0x4035, > + .bInterfaceClass = USB_CLASS_VIDEO, > + .bInterfaceSubClass = 1, > + .bInterfaceProtocol = UVC_PC_PROTOCOL_15, > + .driver_info = (kernel_ulong_t)&(const struct uvc_device_info){ > + .uvc_version = 0x010a, > + } }, > /* LogiLink Wireless Webcam */ > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE > | USB_DEVICE_ID_MATCH_INT_INFO, > > base-commit: fd957081cff04668f390c6f290bdcc7fc009a0f1 > -- > Regards, > > Laurent Pinchart > -- Ricardo Ribalda