Hi Krzysztof, Am Donnerstag, 29. Februar 2024, 19:18:14 CET schrieb Krzysztof Kozlowski: > On 29/02/2024 19:14, Krzysztof Kozlowski wrote: > > On 23/02/2024 15:17, Laurent Pinchart wrote: > >> On Fri, Feb 23, 2024 at 04:16:31PM +0200, Laurent Pinchart wrote: > >>> Hi Alexander, > >>> > >>> Thank you for the patch. > >>> > >>> On Fri, Feb 23, 2024 at 03:04:44PM +0100, Alexander Stein wrote: > >>>> In case the hardware only supports just one pipeline, allow using a > >>>> single port node as well. > >>> > >>> This is frowned upon in DT bindings, as it makes them more complicated > >>> for little gain. The recommendation is to always use a ports node if a > >>> device can have multiple ports for at least one of its compatibles. > >> > >> And reading the cover letter, I see this causes warnings. I think we > >> need guidance from Rob on this. > > > > Here was similar case: > > https://lore.kernel.org/all/20240227142440.GA3863852-robh@xxxxxxxxxx/ > > and @Rob recommendation was to just use ports. > > > > It's true it causes warnings... or I should say - it was causing > > warnings (one of my last warnings in Samsung DTS for W=1). > > > > I wonder what's the base of this patchset? > > > > https://lore.kernel.org/linux-samsung-soc/20231122-dtc-warnings-v2-1-bd4087325392@xxxxxxxxxx/ > > Uh, wait, this was not merged, so the warning still appears. Anyway the > preference is simpler schema, so just "ports". Okay, thanks for that information. I'll drop this patch then. Just to be on the same side, this implies that using a single port in this case ( see patch 3) is not necessary/wanted, no? If so, I'll drop patch 3 as well. Best regards, Alexander -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/
