Hi Mikhail, On Wed, Feb 21, 2024 at 06:02:15PM +0300, Mikhail Rudenko wrote: > > Hi, > > On 2023-12-18 at 20:40 +03, Mikhail Rudenko <mike.rudenko@xxxxxxxxx> wrote: > > > Hi, > > > > This series contains refactoring and new features implementation for > > the Omnivision OV4689 sensor driver. Specifically, patches 1, 2, 3, 5, > > 6, 10, 15, 16, 18, and 19 are refactorings, and are not supposed to > > introduce any functional change. Patches 4 and 7 perform migration to > > CCI helpers and subdevice active state respectively, and should not > > introduce any hardware- and/or user-visible change either. Patch 8 > > fixes a possible race condition due to v4l2_async_register_subdev_sensor > > being called too early in ov4689_probe, and patch 9 migrates power > > management to PM autosuspend. > > > > Patches 11-14 expose more sensor controls to the userspace, such as > > (read-write) HBLANK, VFLIP/HFLIP, digital gain, and color > > balance. Patch 17 implements configurable analogue crop rectangle via > > .set_selection callback. And finally, patch 20 enables 2x2 binning > > option. It should be noted that publicly available sensor > > documentation is lacking description of many registers and their value > > ranges, so a lot of values had to be found by experimentation. > > Gentle ping on this series. Anything I can do to help getting it > reviewed and merged? Maybe split patches 15-20 which implement cropping > and binning and change the driver away from register list based model > into a separate series? Anyone? Oops, my bad. I'll review these shortly. I can already tell there's not much to do though. -- Regards, Sakari Ailus
