On Thu, Feb 15, 2024 at 6:29 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > On Mon, Feb 12, 2024 at 01:13:21PM +0000, Paweł Anikiel wrote: > > The Chameleon v3 uses the framebuffer IP core to take the video signal > > from different sources and directly write frames into memory. > > > > Signed-off-by: Paweł Anikiel <panikiel@xxxxxxxxxx> > > --- > > .../bindings/media/google,chv3-fb.yaml | 77 +++++++++++++++++++ > > 1 file changed, 77 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/google,chv3-fb.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/google,chv3-fb.yaml b/Documentation/devicetree/bindings/media/google,chv3-fb.yaml > > new file mode 100644 > > index 000000000000..ba6643cc7232 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/google,chv3-fb.yaml > > @@ -0,0 +1,77 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/google,chv3-fb.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Google Chameleon v3 video framebuffer > > + > > +maintainers: > > + - Paweł Anikiel <panikiel@xxxxxxxxxx> > > + > > +properties: > > + compatible: > > + const: google,chv3-fb > > + > > + reg: > > + items: > > + - description: core registers > > + - description: irq registers > > + > > + interrupts: > > + maxItems: 1 > > + > > + google,legacy-format: > > + type: boolean > > + description: The incoming video stream is in 32-bit padded mode. > > + > > + google,no-endpoint: > > + type: boolean > > + description: > > + The framebuffer isn't connected to a controllable endpoint. > > + The video interface still works, but EDID control is unavailable > > + and DV timing information only reports the active video width/height. > > Why does this need a dedicated property? Is it not sufficient to check > that there are no endpoints in the devicetree? Yes, I think it is sufficient. I removed the property and added a check in the driver in v2.
