Hi Julien, On Wed, Feb 21, 2024 at 11:34:38AM +0100, Julien Massot wrote: > Hi Sakari, > > On 2/9/24 16:26, Sakari Ailus wrote: > > Hi Julien, > > > > On Thu, Jan 11, 2024 at 02:03:48PM +0100, Julien Massot wrote: > > > This driver handle the MAX96717 serializer in tunnel mode. > > > All incoming CSI traffic will be tunneled through the GMSL2 > > > link. > > > > > > Signed-off-by: Julien Massot <julien.massot@xxxxxxxxxxxxx> > > > --- > > > Change since v2: > > > - Use CCI helpers instead of recoding register access > > > - add missing bitfield header > > > --- > > > MAINTAINERS | 7 + > > > drivers/media/i2c/Kconfig | 13 + > > > drivers/media/i2c/Makefile | 1 + > > > drivers/media/i2c/max96717.c | 956 +++++++++++++++++++++++++++++++++++ > > > 4 files changed, 977 insertions(+) > > > create mode 100644 drivers/media/i2c/max96717.c > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 675e5d63a25b..a64a7932fe76 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -13039,6 +13039,13 @@ S: Maintained > > > F: Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml > > > F: drivers/staging/media/max96712/max96712.c > > > +MAX96717 GMSL2 SERIALIZER DRIVER > > > +M: Julien Massot <julien.massot@xxxxxxxxxxxxx> > > > +L: linux-media@xxxxxxxxxxxxxxx > > > +S: Maintained > > > +F: Documentation/devicetree/bindings/media/i2c/maxim,max96717f.yaml > > > > What's that "f" for? It's in bindings but not in the name of the driver. > > Not a typo I suppose? :-) > > Indeed that's not a typo, the Maxim's GMSL2 chips are available under > multiple > variants: > - MAX96717 which supports GMSL link speed 6 and 3Gbps and CSI lanes up to > 2.5Gbps > - MAX96717K which supports GMSL link speed 6 and 3Gbps and CSI lanes up to > 1.5Gbps > - MAX96717F which only supports GMSL link speed 3Gbps and CSI lanes up to > 2.5Gbps > > They have the same register mapping, so we should be able to add support for > the other variants in the future. I think you should probably do this for the bindings, too. I'd thus drop "f" from the file name. -- Regards, Sakari Ailus
