On Mon, 19 Feb 2024 18:18:55 +0100, Marc Gonzalez wrote: > From: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> > > On our msm8998-based device, calling venus_sys_set_power_control() > breaks playback. Since the vendor kernel never calls it, we assume > it should not be called for this device/FW combo. > > Signed-off-by: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> > Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx> > --- > TODO in v2: split the patch in 2 > Is "qcom,no-low-power" a proper name for the property? > Is a boolean property the right approach? > --- > .../devicetree/bindings/media/qcom,venus-common.yaml | 3 +++ > drivers/media/platform/qcom/venus/hfi_venus.c | 9 +++++---- > 2 files changed, 8 insertions(+), 4 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/qcom,venus-common.yaml: properties:qcom,no-low-power: 'description' is a dependency of 'type' hint: Vendor specific properties must have a type and description unless they have a defined, common suffix. from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/0843621b-386b-4173-9e3c-9538cdb4641d@xxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
