Hi,
On 1/2/24 01:19, Andy Shevchenko wrote:
> On Sun, Dec 31, 2023 at 12:31 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>>
>> Now that a single build supports both the ISP 2400 and the ISP 2401
>> this function is no longer necessary. The main probe() already
>> contains a similar switch (id->device & ATOMISP_PCI_DEVICE_SOC_MASK)
>> checking for a known device_id.
>>
>> Move the revision check into the main probe() and drop
>> the is_valid_device() function.
>
> ...
>
>> + if (pdev->revision <= ATOMISP_PCI_REV_BYT_A0_MAX) {
>> + dev_err(&pdev->dev, "revision %d is not unsupported\n", pdev->revision);
>
> While at it, can you fix the logic error in the message ("is not un"
> -- double negation)?
Good point, I've added a patch for this to my upcoming
atomisp pull-req for 6.9
Regards,
Hans
