On Fri, Feb 16, 2024 at 02:45:31PM +0000, Dan Scally wrote: > > > > > > > + - description: ISP AXI clock > > > > > > > + - description: ISP AHB-lite clock > > > > > > These two other clocks look good to me. > > > > > > > > > > > > > + > > > > > > > + clock-names: > > > > > > > + items: > > > > > > > + - const: vclk > > > > > > > + - const: aclk > > > > > > > + - const: hclk > > > > > Why not "video" "axi" "ahb-lite"? There's 3 useful letters between the > > > > > tree clock names you've provided - they're all clocks, so having "clk" > > > > > in them is just noise :) > > > > As far as I understand, the names proposed by Dan come directly from the > > > > IP core documentation. > > > This is the case, but I do take Conor's point that more descriptive names might be nicer - if I'm > > > honest I just didn't think about it particularly given "Xclk" is such a common name for them > > > already, but having been poked into thinking about it I do agree. > > Isn't the usual practice in DT bindings is to name GPIOs, clocks and reset > > signals based on the hardware documentation ? > > > Ah - I don't know honestly. If that's so then yeah - these are the names the documentation prescribes. If a direct doc match is what you're going for, then sure, keep it.
Attachment:
signature.asc
Description: PGP signature
