cl in struct cmdq_pkt is used to store struct cmdq_client, but every client driver has the struct cmdq_client information, so it's not necessary to store struct cmdq_client in struct cmdq_pkt. Because mailbox maintainer do not like to mix mailbox patch with other patches in a series, so mailbox patch [1] would be sent independently. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/commit/?h=mediatek-cmdq8&id=a1b2f7a7488285975c1f439086f1c4cc51a13bb9 Chun-Kuang Hu (9): soc: mediatek: cmdq: Remove unused helper funciton soc: mediatek: cmdq: Add parameter shift_pa to cmdq_pkt_jump() soc: mediatek: cmdq: Add cmdq_pkt_eoc() helper function soc: mediatek: cmdq: Add cmdq_pkt_nop() helper function drm/mediatek: Drop calling cmdq_pkt_finalize() media: platform: mtk-mdp3: drop calling cmdq_pkt_finalize() soc: mediatek: cmdq: Remove cmdq_pkt_finalize() helper function drm/mediatek: Do not store struct cmdq_client in struct cmdq_pkt media: platform: mtk-mdp3: do not store struct cmdq_client in struct cmdq_pkt drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 9 +- .../platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 14 ++- .../platform/mediatek/mdp3/mtk-mdp3-core.c | 2 + .../platform/mediatek/mdp3/mtk-mdp3-core.h | 1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 85 +++---------------- include/linux/soc/mediatek/mtk-cmdq.h | 50 ++++------- 6 files changed, 39 insertions(+), 122 deletions(-) -- 2.34.1