Hi Andy, On 07/02/2024 16:36, Andy Chen wrote: > Hi, > > find_csis_format() may return NULL, and we should determine its return value > to prevent a fatal error when later functions use it. > > diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c > index db8ff5f5c4d3..ac867620e2ba 100644 > --- a/drivers/media/platform/nxp/imx-mipi-csis.c > +++ b/drivers/media/platform/nxp/imx-mipi-csis.c > @@ -956,6 +956,8 @@ static int mipi_csis_s_stream(struct v4l2_subdev *sd, int enable) > > format = v4l2_subdev_state_get_format(state, CSIS_PAD_SINK); > csis_fmt = find_csis_format(format->code); > + if (!csis_fmt) > + return -EPIPE; > > ret = mipi_csis_calculate_params(csis, csis_fmt); > if (ret < 0) > > This is my first patch, any suggestions are welcome, thanks! This is missing your Signed-off-by line. Much more information on how to submit patches is given here: https://docs.kernel.org/process/submitting-patches.html But typically patches are formatted like this: https://patchwork.linuxtv.org/project/linux-media/patch/20231216133422.2534674-2-jernej.skrabec@xxxxxxxxx/ One question for this patch: have you observed that find_csis_format() can return NULL, or do you just think that can happen? Regards, Hans
