On Mon, Feb 05, 2024 at 01:07:03PM +0100, Hans Verkuil wrote:
> On 01/02/2024 14:17, Laurent Pinchart wrote:
> > Hello Hans and Mauro,
> >
> > The following changes since commit feb8831be9d468ee961289c6a275536a1ee0011c:
> >
> > media: ov08x40: Reduce start streaming time (2024-02-01 13:45:19 +0100)
> >
> > are available in the Git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git tags/media-imx-next-20240131
> >
> > for you to fetch changes up to 87a913cc4385da5313208ae240484fa2c591eb2e:
> >
> > media: nxp: imx8-isi: Factor out a variable (2024-02-01 15:12:32 +0200)
> >
> > ----------------------------------------------------------------
> > - Fix handling of MEDIA_PAD_FL_MUST_CONNECT flag in V4L2 core
> > - Fix MUST_CONNECT-related crash in the imx8-isi driver
> > - Fix compiler warning in imx8-isi driver
> >
> > ----------------------------------------------------------------
> > Laurent Pinchart (6):
> > media: mc: Add local pad to pipeline regardless of the link state
> > media: mc: Fix flags handling when creating pad links
> > media: mc: Add num_links flag to media_pad
> > media: mc: Rename pad variable to clarify intent
> > media: mc: Expand MUST_CONNECT flag to always require an enabled link
> > media: nxp: imx8-isi: Mark all crossbar sink pads as MUST_CONNECT
> >
> > Marek Vasut (1):
> > media: nxp: imx8-isi: Check whether crossbar pad is non-NULL before access
>
> All the patches above have a CC to stable, but only 2 have a Fixes tag. Is that
> intended or are the Fixes tags missing? It's odd to CC to stable without a Fixes
> tag.
That's intended.
Commit "media: mc: Add local pad to pipeline regardless of the link
state" is a standalone bug fix and has a Fixes: tag. No problem there.
Commit "media: nxp: imx8-isi: Check whether crossbar pad is non-NULL
before access" is another fix, and depends on the previous commit
("media: mc: Fix flags handling when creating pad links"), which is
CC'ed to stable as it's a dependency.
The fix in "media: nxp: imx8-isi: Check whether crossbar pad is non-NULL
before access" is a bit of a hack though, as it addresses the imx8-isi
driver only, while the problem is more widespread. The subsequent
commits implement a better fix, which is why I CC'ed them to stable too.
As the original problem is already fixed by a previous commit, there's
no new Fixes: tag.
I could have dropped "media: nxp: imx8-isi: Check whether crossbar pad
is non-NULL before access" in favour of the more generic fix, but I
decided to keep it in case the more generic rework ends up introducing a
problem and needs to be reverted.
> > Ricardo Ribalda (1):
> > media: nxp: imx8-isi: Factor out a variable
> >
> > .../userspace-api/media/mediactl/media-types.rst | 11 ++-
> > drivers/media/mc/mc-entity.c | 93 ++++++++++++++++------
> > .../platform/nxp/imx8-isi/imx8-isi-crossbar.c | 4 +-
> > drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c | 8 +-
> > include/media/media-entity.h | 2 +
> > 5 files changed, 81 insertions(+), 37 deletions(-)
> >
--
Regards,
Laurent Pinchart
