Re: [PATCH] media: v4l2-common.h: kerneldoc: correctly format return values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Fri, Feb 02, 2024 at 09:25:44AM +0100, Hans Verkuil wrote:
> Building the kerneldoc resulted in two errors:
> 
> Documentation/media/driver-api/v4l2-common:6: ./include/media/v4l2-common.h:566: ERROR: Unexpected indentation.
> Documentation/media/driver-api/v4l2-common:6: ./include/media/v4l2-common.h:567: WARNING: Block quote ends without a blank line; unexpected unindent.
> 
> Format v4l2_link_freq_to_bitmap according to the kerneldoc standard.
> The v4l2_fill_pixfmt_mp function also had incorrect return value formatting,
> although that didn't report an error/warning, but it looked ugly in the
> generated documentation. So fix that one as well.
> 
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
> Fixes: a68e88e2cf9e ("media: v4l: Add a helper for setting up link-frequencies control")

I wrote a patch to address these as well but I think yours is better.

Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

-- 
Regards,

Sakari Ailus




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux