Hello Sebastian Thanks for your advice. > -----Original Message----- > From: Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx> > Sent: Friday, February 2, 2024 5:16 PM > To: jackson.lee <jackson.lee@xxxxxxxxxxxxxxx> > Cc: mchehab@xxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; lafley.kim <lafley.kim@xxxxxxxxxxxxxxx>; b- > brnich@xxxxxx; hverkuil@xxxxxxxxx; Nas Chung <nas.chung@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH v1 0/5] wave5 codec driver > > Hey Jackson, > > thanks for sending the patches! > > I would advise to not send the next version of a patch series with > multiple patches too quickly. So far the patches only got a single very > minor review comment and others might already work on a deeper review and > test. There is no hard rule but I would say give such a series at least a > week or two to gather some review comments before sending the next version, > as it is always a bit of hassle to adjust to a new version and you don't > want to spam the mailing list. > Should you not receive any more review comments, then please go ahead and > ping some relevant people (Hans Verkuil, people from Collabora that > developed the patches, etc.) to review, either per mail or per IRC on the > OFTC server on the channel #linux-media. > > Greetings, > Sebastian > > On 02.02.2024 16:03, jackson.lee wrote: > >The wave5 codec driver is a stateful encoder/decoder. > >The following patches is for supporting yuv422 inpuy format, supporting > >runtime suspend/resume feature and extra things. > > > >Change since v0: > >================= > >The DEFAULT_SRC_SIZE macro was defined using multiple lines, To make a > >simple define, tab and multiple lines has been removed, The macro is > >defined using one line. > > > > > >jackson.lee (5): > > wave5 : Support yuv422 input format for encoder. > > wave5: Support to prepend sps/pps to IDR frame. > > wave5 : Support runtime suspend/resume. > > wave5: Use the bitstream buffer size from host. > > wave5 : Fixed the wrong buffer size formula. > > > > .../platform/chips-media/wave5/wave5-hw.c | 11 +- > > .../chips-media/wave5/wave5-vpu-dec.c | 86 +++++----- > > .../chips-media/wave5/wave5-vpu-enc.c | 157 +++++++++++++++--- > > .../platform/chips-media/wave5/wave5-vpu.c | 68 ++++++++ > > .../platform/chips-media/wave5/wave5-vpuapi.c | 7 + > > .../platform/chips-media/wave5/wave5-vpuapi.h | 1 + > > .../media/platform/chips-media/wave5/wave5.h | 3 + > > 7 files changed, 253 insertions(+), 80 deletions(-) > > > >-- > >2.43.0 > > > >
