Hi Ricardo,
Thank you for the patch.
On Sun, Jan 28, 2024 at 04:13:56PM +0000, Ricardo Ribalda wrote:
> gcc-11 seems to believe that coffs can be used uninitialized. Refactor
s/coffs/coeffs/
> the code and remove the csen variable to convince gcc that we are doing
s/csen/cscen/
> a good job.
>
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:218:20: warning: 'coeffs' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c
> index 19e80b95ffea..5623914f95e6 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c
> @@ -215,8 +215,7 @@ static void mxc_isi_channel_set_csc(struct mxc_isi_pipe *pipe,
> [MXC_ISI_ENC_RGB] = "RGB",
> [MXC_ISI_ENC_YUV] = "YUV",
> };
> - const u32 *coeffs;
> - bool cscen = true;
> + const u32 *coeffs = NULL;
> u32 val;
>
> val = mxc_isi_read(pipe, CHNL_IMG_CTRL);
> @@ -235,14 +234,13 @@ static void mxc_isi_channel_set_csc(struct mxc_isi_pipe *pipe,
> val |= CHNL_IMG_CTRL_CSC_MODE(CHNL_IMG_CTRL_CSC_MODE_RGB2YCBCR);
> } else {
> /* Bypass CSC */
> - cscen = false;
> val |= CHNL_IMG_CTRL_CSC_BYPASS;
> }
>
> dev_dbg(pipe->isi->dev, "CSC: %s -> %s\n",
> encodings[in_encoding], encodings[out_encoding]);
>
> - if (cscen) {
> + if (coeffs) {
> mxc_isi_write(pipe, CHNL_CSC_COEFF0, coeffs[0]);
> mxc_isi_write(pipe, CHNL_CSC_COEFF1, coeffs[1]);
> mxc_isi_write(pipe, CHNL_CSC_COEFF2, coeffs[2]);
> @@ -253,7 +251,7 @@ static void mxc_isi_channel_set_csc(struct mxc_isi_pipe *pipe,
>
> mxc_isi_write(pipe, CHNL_IMG_CTRL, val);
>
> - *bypass = !cscen;
> + *bypass = !coeffs;
> }
>
> void mxc_isi_channel_set_alpha(struct mxc_isi_pipe *pipe, u8 alpha)
>
--
Regards,
Laurent Pinchart
