Hi Fei, Thanks for the corrections. On Mon, 2024-01-22 at 11:44 +0800, Fei Shao wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Fri, Jan 19, 2024 at 2:32 PM Jason-JH.Lin < > jason-jh.lin@xxxxxxxxxxxx> wrote: > Hi Jason, > > Just few nitpicks about typo: > > > > Add mediatek,gce-props.yaml for common GCE properties that is used > for > > both mailbox providers and consumers. We place the common property > > "mediatek,gce-events" in this binding currently. > > > > The property "mediatek,gce-events" is used for GCE event ID > corresponding > > to a hardware event signal sent by the hardware or a sofware > driver. > software > > > If the mailbox providers or consumers want to manipulate the value > of > > the event ID, they need to know the specific event ID. > > > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx> > > --- > > .../bindings/mailbox/mediatek,gce-props.yaml | 52 > +++++++++++++++++++ > > 1 file changed, 52 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/mailbox/mediatek,gce-props.yaml > > > > diff --git > a/Documentation/devicetree/bindings/mailbox/mediatek,gce-props.yaml > b/Documentation/devicetree/bindings/mailbox/mediatek,gce-props.yaml > > new file mode 100644 > > index 000000000000..68b519ff089f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce- > props.yaml > > @@ -0,0 +1,52 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > http://devicetree.org/schemas/mailbox/mediatek,gce-props.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek Global Command Engine Common Propertes > Properties > > > + > > +maintainers: > > + - Houlong Wei <houlong.wei@xxxxxxxxxxxx> > > + > > +description: > > + The Global Command Engine (GCE) is an instruction based, multi- > threaded, > > + single-core command dispatcher for MediaTek hardware. The > Command Queue > > + (CMDQ) mailbox driver is a driver for GCE, implemented using the > Linux > > + mailbox framework. It is used to receive messages from mailbox > consumers > > + and configure GCE to execute the specified instruction set in > the message. > > + We use mediatek,gce-mailbox.yaml to define the properties for > CMDQ mailbox > > + driver. A device driver that uses the CMDQ driver to configure > its hardware > > + registers is a mailbox consumer. The mailbox consumer can > request a mailbox > > + channel corresponding to a GCE hardware thread to send a > message, specifying > > + that the GCE thread to configure its hardware. The mailbox > provider can also > > + reserved a mailbox channel to configure GCE hardware register by > the spcific > s/reserved/reserve/ > s/spcific/specific/ > > Regards, > Fei > I'll fix these typo in the next version. Regards, Jason-JH.Lin