On Tue, Jan 16, 2024 at 03:35:16PM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Tue, Jan 16, 2024 at 11:27:29AM +0000, Sakari Ailus wrote:
> > On Tue, Jan 16, 2024 at 10:42:34AM +0200, Laurent Pinchart wrote:
> > > When building pipelines by following links, the
> > > media_pipeline_explore_next_link() function only traverses enabled
> > > links. The remote pad of a disabled link is not added to the pipeline,
> > > and neither is the local pad. While the former is correct as disabled
> > > links should not be followed, not adding the local pad breaks processing
> > > of the MEDIA_PAD_FL_MUST_CONNECT flag.
> > >
> > > The MEDIA_PAD_FL_MUST_CONNECT flag is checked in the
> > > __media_pipeline_start() function that iterates over all pads after
> > > populating the pipeline. If the pad is not present, the check gets
> > > skipped, rendering it useless.
> > >
> > > Fix this by adding the local pad of all links regardless of their state,
> > > only skipping the remote pad for disabled links.
> > >
> > > Cc: Alexander Shiyan <eagle.alexander923@xxxxxxxxx>
> > > Fixes: ae219872834a ("media: mc: entity: Rewrite media_pipeline_start()")
> > > Reported-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
> > > Closes: https://lore.kernel.org/linux-media/7658a15a-80c5-219f-2477-2a94ba6c6ba1@xxxxxxxxxx
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > > Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> >
> > Could you add Cc: stable when sending the PR? This should be applied to 6.1
> > and later.
>
> I'll do so, far all patches in the series.
Thanks!
--
Sakari Ailus
