Re: [PATCH] media: v4l2: cci: print leading 0 on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 1/11/24 14:20, Julien Massot wrote:
> In some error cases leading '0' for register address
> were missing.
> 
> Fixes: 613cbb91e9ce ("media: Add MIPI CCI register access helper functions")
> Signed-off-by: Julien Massot <julien.massot@xxxxxxxxxxxxx>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans



> ---
>  drivers/media/v4l2-core/v4l2-cci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-cci.c b/drivers/media/v4l2-core/v4l2-cci.c
> index 10005c80f43b..ee3475bed37f 100644
> --- a/drivers/media/v4l2-core/v4l2-cci.c
> +++ b/drivers/media/v4l2-core/v4l2-cci.c
> @@ -32,7 +32,7 @@ int cci_read(struct regmap *map, u32 reg, u64 *val, int *err)
>  
>  	ret = regmap_bulk_read(map, reg, buf, len);
>  	if (ret) {
> -		dev_err(regmap_get_device(map), "Error reading reg 0x%4x: %d\n",
> +		dev_err(regmap_get_device(map), "Error reading reg 0x%04x: %d\n",
>  			reg, ret);
>  		goto out;
>  	}
> @@ -131,7 +131,7 @@ int cci_write(struct regmap *map, u32 reg, u64 val, int *err)
>  
>  	ret = regmap_bulk_write(map, reg, buf, len);
>  	if (ret)
> -		dev_err(regmap_get_device(map), "Error writing reg 0x%4x: %d\n",
> +		dev_err(regmap_get_device(map), "Error writing reg 0x%04x: %d\n",
>  			reg, ret);
>  
>  out:





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux