On Tue, Jan 09, 2024 at 04:06:03PM +0000, Bryan O'Donoghue wrote: > Add bindings for qcom,sc8280xp-camss in order to support the camera > subsystem for sc8280xp as found in the Lenovo x13s Laptop. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- This is where you mention dependencies. Didn't I say this already? > .../bindings/media/qcom,sc8280xp-camss.yaml | 512 +++++++++++++++++++++ > 1 file changed, 512 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml > new file mode 100644 > index 000000000000..c0bc31709873 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml > @@ -0,0 +1,512 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/qcom,sc8280xp-camss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm SC8280XP Camera Subsystem (CAMSS) > + > +maintainers: > + - Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > + > +description: | If you resend, don't need '|' here. > + The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms.