On 09/01/2024 03:27, Zhi Mao wrote: > Add YAML device tree binding for GC08A3 CMOS image sensor, > and the relevant MAINTAINERS entries. > A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Subject: only one "media", so: media: dt-bindings: i2c: add GalaxyCore GC08A3 image sensor > Signed-off-by: Zhi Mao <zhi.mao@xxxxxxxxxxxx> ... > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + sensor0@31 { sensor@31 With above fixed: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Before you reply, fix your email client. It's impossible to read your responses. Best regards, Krzysztof
