On Tue, Jan 09, 2024 at 05:09:09PM +0900, Hidenori Kobayashi wrote: > The imgu driver fails to probe with the following message because it > does not set the pad's flags before calling media_entity_pads_init(). > > [ 14.596315] ipu3-imgu 0000:00:05.0: failed initialize subdev media entity (-22) > [ 14.596322] ipu3-imgu 0000:00:05.0: failed to register subdev0 ret (-22) > [ 14.596327] ipu3-imgu 0000:00:05.0: failed to register pipes (-22) > [ 14.596331] ipu3-imgu 0000:00:05.0: failed to create V4L2 devices (-22) > > Fix the initialization order so that the driver probe succeeds. The ops > initialization is also moved together for readability. > > Fixes: a0ca1627b450 ("media: staging/intel-ipu3: Add v4l2 driver based on media framework") > Cc: <stable@xxxxxxxxxxxxxxx> # 6.7 > Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Hidenori Kobayashi <hidenorik@xxxxxxxxxxxx> > --- Thanks so much! regards, dan carpenter